[
https://issues.apache.org/jira/browse/KAFKA-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290284#comment-13290284
]
Joel Koshy commented on KAFKA-341:
----------------------------------
I remembered I also had some review comments lying around.
John - I think it's great that we now have this system test to help
with 0.8 development. Brief comments - may have overlap with
Jun's:
- kafka-run-class should be removed.
- Add readme.
- run-test.sh:
- typo on line 56 in var name, but doesn't hurt
- typo on line 65 in var name, but doesn't hurt
- line 94-97: cut is brittle for this purpose. Better to use sed/awk.
- There are a lot of util functions such as info, kill_child_processes
that we use in all our scripts. It would be good to factor these out
into a common script and source it from the system tests.
- No need any references to any target cluster. E.g., zk_target,
kafka_target, etc. Likewise, should rename *_source_cluster to simply
*_cluster.
> Create a new single host system test to validate all replicas on 0.8 branch
> ---------------------------------------------------------------------------
>
> Key: KAFKA-341
> URL: https://issues.apache.org/jira/browse/KAFKA-341
> Project: Kafka
> Issue Type: Task
> Reporter: John Fung
> Assignee: John Fung
> Attachments: kafka-341-v1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
