[
https://issues.apache.org/jira/browse/KAFKA-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-385:
-----------------------------
Attachment: KAFKA-385-v2.patch
The jira system was down around the time of my last comment and it was not
sent to the mailing list. That further explains some of these updates.
1 - Added produce satisfied stats.
2 - Common request key for fetch/produce.
3 - Factory method for getAndMaybePut.
4 - Added doc describing fudged name for KafkaMetricsGroup.
5 - Fixed the issues with the JMX operations I had earlier.
6 - Reverted the ProducerPerformance and temporary config changes.
I decided against doing the optimization for the FetchRequestPurgatory
checkSatisfied as I don't think it makes a significant difference, as the
available bytes computation is pretty much in memory.
One more comment on the usage of metrics: it is possible to combine
rate/histogram metrics into a metrics Timer object. I chose not to do this
because the code turns out a little cleaner by using a meter/histogram, but
will revisit later.
> RequestPurgatory enhancements - expire/checkSatisfy issue; add jmx beans
> ------------------------------------------------------------------------
>
> Key: KAFKA-385
> URL: https://issues.apache.org/jira/browse/KAFKA-385
> Project: Kafka
> Issue Type: Bug
> Reporter: Joel Koshy
> Assignee: Joel Koshy
> Fix For: 0.8
>
> Attachments: example_dashboard.jpg, graphite_explorer.jpg,
> KAFKA-385-v1.patch, KAFKA-385-v2.patch
>
>
> As discussed in KAFKA-353:
> 1 - There is potential for a client-side race condition in the
> implementations of expire and checkSatisfied. We can just synchronize on the
> DelayedItem.
> 2 - Would be good to add jmx beans to facilitate monitoring RequestPurgatory
> stats.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
