[
https://issues.apache.org/jira/browse/KAFKA-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434332#comment-13434332
]
Neha Narkhede commented on KAFKA-385:
-------------------------------------
Patch v2 doesn't apply cleanly on a fresh checkout of 0.8 -
nnarkhed-ld:kafka-385 nnarkhed$ patch -p0 -i
~/Projects/kafka-patches/KAFKA-385-v2.patch
patching file core/src/main/scala/kafka/Kafka.scala
patching file core/src/main/scala/kafka/api/FetchResponse.scala
patching file core/src/main/scala/kafka/metrics/KafkaMetrics.scala
patching file core/src/main/scala/kafka/metrics/KafkaMetricsConfigShared.scala
patching file core/src/main/scala/kafka/metrics/KafkaMetricsGroup.scala
patching file core/src/main/scala/kafka/server/KafkaApis.scala
Hunk #4 FAILED at 160.
Hunk #12 FAILED at 360.
2 out of 24 hunks FAILED -- saving rejects to file
core/src/main/scala/kafka/server/KafkaApis.scala.rej
patching file core/src/main/scala/kafka/server/KafkaConfig.scala
Hunk #1 succeeded at 24 with fuzz 2 (offset 2 lines).
Hunk #2 succeeded at 36 with fuzz 1 (offset 2 lines).
Hunk #3 succeeded at 139 (offset 2 lines).
patching file core/src/main/scala/kafka/server/RequestPurgatory.scala
patching file core/src/main/scala/kafka/utils/Pool.scala
patching file core/src/main/scala/kafka/utils/Utils.scala
Hunk #1 succeeded at 502 (offset 1 line).
patching file core/src/test/scala/unit/kafka/integration/LogCorruptionTest.scala
patching file core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala
patching file core/src/test/scala/unit/kafka/server/RequestPurgatoryTest.scala
patching file project/build/KafkaProject.scala
> RequestPurgatory enhancements - expire/checkSatisfy issue; add jmx beans
> ------------------------------------------------------------------------
>
> Key: KAFKA-385
> URL: https://issues.apache.org/jira/browse/KAFKA-385
> Project: Kafka
> Issue Type: Bug
> Reporter: Joel Koshy
> Assignee: Joel Koshy
> Fix For: 0.8
>
> Attachments: example_dashboard.jpg, graphite_explorer.jpg,
> KAFKA-385-v1.patch, KAFKA-385-v2.patch
>
>
> As discussed in KAFKA-353:
> 1 - There is potential for a client-side race condition in the
> implementations of expire and checkSatisfied. We can just synchronize on the
> DelayedItem.
> 2 - Would be good to add jmx beans to facilitate monitoring RequestPurgatory
> stats.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
