[ 
https://issues.apache.org/jira/browse/KAFKA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435429#comment-13435429
 ] 

Jay Kreps commented on KAFKA-356:
---------------------------------

Can we just give the logger the right class name?
                
> Create a generic Kafka thread class that includes basic boiler plate code of 
> instantiating and shutting down threads cleanly
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-356
>                 URL: https://issues.apache.org/jira/browse/KAFKA-356
>             Project: Kafka
>          Issue Type: Sub-task
>    Affects Versions: 0.8
>            Reporter: Neha Narkhede
>            Assignee: Yang Ye
>              Labels: optimization
>         Attachments: kafka_356_v1.diff, kafka_356_v2.diff
>
>
> We have a lot of threads that basically run in a loop and use an isRunning 
> atomic boolean and count down latch. It will be useful to refactor it out 
> into a helper runnable that these can extend. Verifying the lifecycle details 
> for each is kind of a pain and it pretty easy to either not cleanly shutdown 
> all the threads.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to