[
https://issues.apache.org/jira/browse/KAFKA-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437214#comment-13437214
]
Jun Rao commented on KAFKA-356:
-------------------------------
Thanks for patch v5. system_test/single_host_multiple_brokers now hangs. It
seems that the unit test can't find the leader broker id. This is likely
because some the of log messages have changed and the unit test script is not
updated according.
2012-08-17 19:01:41 =======================================
2012-08-17 19:01:41 Iteration 1 of 3
2012-08-17 19:01:41 =======================================
2012-08-17 19:01:41 looking up leader
2012-08-17 19:01:41 found the log line: [2012-08-17 19:01:36,221] INFO [Replica
Manager on Broker 1], completed the leader state transition for topic mytest
partition 0 (kafka.server.ReplicaManager)
bin/run-test.sh: line 155: return: [2012-08-17: numeric argument required
2012-08-17 19:01:41 current leader's broker id : 255
2012-08-17 19:01:41 stopping server: 255
2012-08-17 19:01:41 sleeping for 10s
> Create a generic Kafka thread class that includes basic boiler plate code of
> instantiating and shutting down threads cleanly
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-356
> URL: https://issues.apache.org/jira/browse/KAFKA-356
> Project: Kafka
> Issue Type: Sub-task
> Affects Versions: 0.8
> Reporter: Neha Narkhede
> Assignee: Yang Ye
> Labels: optimization
> Attachments: kafka_356_v1.diff, kafka_356_v2.diff, kafka_356_v3.diff,
> kafka_356_v4.diff, kafka_356_v5.diff
>
>
> We have a lot of threads that basically run in a loop and use an isRunning
> atomic boolean and count down latch. It will be useful to refactor it out
> into a helper runnable that these can extend. Verifying the lifecycle details
> for each is kind of a pain and it pretty easy to either not cleanly shutdown
> all the threads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
