[
https://issues.apache.org/jira/browse/KAFKA-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435782#comment-13435782
]
Joel Koshy commented on KAFKA-385:
----------------------------------
That's a good suggestion, and should work as well. I'll make that change
tomorrow. It would be good to understand the lazy val implementation as well -
will try and dig into some toy examples.
30. Correct - I had reverted that in the last attachment. There was a
(temporary I think) reason I needed that default but I don't remember.
For 31 and 32 I think we should defer this to a later discussion. I actually
had expiration time before but removed it. I'm not sure it makes a lot of
sense. It would perhaps be useful to detect producers that are setting a very
low expiration period, but even so it is driven by producer configs and would
be a mash-up of values from different producers with expiring requests. Stats
can be asymmetric between delayed-produce/delayed-fetch and also between
expired/satisfied.
> RequestPurgatory enhancements - expire/checkSatisfy issue; add jmx beans
> ------------------------------------------------------------------------
>
> Key: KAFKA-385
> URL: https://issues.apache.org/jira/browse/KAFKA-385
> Project: Kafka
> Issue Type: Bug
> Reporter: Joel Koshy
> Assignee: Joel Koshy
> Labels: bugs
> Fix For: 0.8
>
> Attachments: example_dashboard.jpg, graphite_explorer.jpg,
> KAFKA-385-v1.patch, KAFKA-385-v2.patch, KAFKA-385-v3.patch,
> KAFKA-385-v3.patch, KAFKA-385-v3-with-lazy-fix.patch
>
>
> As discussed in KAFKA-353:
> 1 - There is potential for a client-side race condition in the
> implementations of expire and checkSatisfied. We can just synchronize on the
> DelayedItem.
> 2 - Would be good to add jmx beans to facilitate monitoring RequestPurgatory
> stats.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
