[
https://issues.apache.org/jira/browse/KAFKA-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435753#comment-13435753
]
Jun Rao commented on KAFKA-385:
-------------------------------
For the issue with getAndMaybePut(), can we add an optional createValue()
method to the constructor of Pool? If an object doesn't exist for a key, Pool
can call createValue() to create a new value object from key.
A few other comments:
30. KafkaConfig: brokerid should be a required property. So we shouldn't put a
default value.
31. satisfiedRequestMeter: Currently, it doesn't include the time for expired
requests. I prefer to have a stat that gives the time for all requests, whether
expired or not.
32. I am not sure how useful the metric CaughtUpFollowerFetchRequestsPerSecond
is.
> RequestPurgatory enhancements - expire/checkSatisfy issue; add jmx beans
> ------------------------------------------------------------------------
>
> Key: KAFKA-385
> URL: https://issues.apache.org/jira/browse/KAFKA-385
> Project: Kafka
> Issue Type: Bug
> Reporter: Joel Koshy
> Assignee: Joel Koshy
> Labels: bugs
> Fix For: 0.8
>
> Attachments: example_dashboard.jpg, graphite_explorer.jpg,
> KAFKA-385-v1.patch, KAFKA-385-v2.patch, KAFKA-385-v3.patch,
> KAFKA-385-v3.patch, KAFKA-385-v3-with-lazy-fix.patch
>
>
> As discussed in KAFKA-353:
> 1 - There is potential for a client-side race condition in the
> implementations of expire and checkSatisfied. We can just synchronize on the
> DelayedItem.
> 2 - Would be good to add jmx beans to facilitate monitoring RequestPurgatory
> stats.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
