[ 
https://issues.apache.org/jira/browse/KAFKA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436802#comment-13436802
 ] 

Jun Rao commented on KAFKA-324:
-------------------------------

How about we add a new getIntInRange() that doesn't take default (i.e., a 
required field) and use that for setting broker.id in KafkaConfig? If we think 
require is more intuitive, we can change all get* helper functions to use 
require. This way, all properties are set in the same style in KafkaConfig.
                
> enforce broker.id to be a non-negative integer
> ----------------------------------------------
>
>                 Key: KAFKA-324
>                 URL: https://issues.apache.org/jira/browse/KAFKA-324
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Swapnil Ghike
>              Labels: newbie, noob
>         Attachments: kafka-324.patch, kafka-324-v2.patch
>
>
> In DefaultEventHandler, it seems that we rely on the fact that broker.id is a 
> non-negative integer. However, we don't enforce that in broker startup. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to