[
https://issues.apache.org/jira/browse/KAFKA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436973#comment-13436973
]
Jun Rao commented on KAFKA-324:
-------------------------------
Thanks for patch v3. Looks good overall. One comment:
1. For all get* in utils that take ByteBuffer, we should throw KafkaException,
instead of IllegalArgumentException since they are not argument errors.
> enforce broker.id to be a non-negative integer
> ----------------------------------------------
>
> Key: KAFKA-324
> URL: https://issues.apache.org/jira/browse/KAFKA-324
> Project: Kafka
> Issue Type: Improvement
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: newbie, noob
> Attachments: kafka-324.patch, kafka-324-v2.patch, kafka-324-v3.patch
>
>
> In DefaultEventHandler, it seems that we rely on the fact that broker.id is a
> non-negative integer. However, we don't enforce that in broker startup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
