[ 
https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prashanth Menon updated KAFKA-376:
----------------------------------

    Attachment: KAFKA-376-v4.patch

Hi all,

So I've attached a new patch that addresses all the points except the second 
point in 30.2 .  It looks like using EasyMock to mock methods with optional 
arguments is tricky; the call to ReplicaManager.getReplica is causing issues 
because the brokerId is optional.  I suspect the Scala compiler produces 
several versions of the method that are chained together at runtime, but which 
EasyMock can't resolve for some reason.  I've tried some trickery to no avail.

It's a bad idea to modify code to accomadate faulty test/tools, but I figured 
I'd attach a patch for review while I check out other options.  Let me know 
what you think,
                
> expose different data to fetch requests from the follower replicas and 
> consumer clients
> ---------------------------------------------------------------------------------------
>
>                 Key: KAFKA-376
>                 URL: https://issues.apache.org/jira/browse/KAFKA-376
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Prashanth Menon
>              Labels: bugs
>         Attachments: KAFKA-376-DRAFT.patch, KAFKA-376-v1.patch, 
> KAFKA-376-v2.patch, KAFKA-376-v3.patch, KAFKA-376-v4.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Currently, the broker always uses highwatermark to calculate the available 
> bytes to a fetch request, no matter where the request is from. Instead, we 
> should use highwatermark for requests coming from real consumer clients and 
> use logendoffset for requests coming from follower replicas.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to