[ 
https://issues.apache.org/jira/browse/KAFKA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451713#comment-13451713
 ] 

Jun Rao commented on KAFKA-376:
-------------------------------

Thanks for patch v6. We probably should do the length check inside log.read() , 
instead of readMessageSet. This way, we make sure that the caller's offset is 
checked by Log.findRange and an OffsetOutOfRangeException can be thrown if 
needed. In log.read(), after Log.findRange, we can check if length is <=0  and 
if so, immediately return an empty set.
                
> expose different data to fetch requests from the follower replicas and 
> consumer clients
> ---------------------------------------------------------------------------------------
>
>                 Key: KAFKA-376
>                 URL: https://issues.apache.org/jira/browse/KAFKA-376
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8
>            Reporter: Jun Rao
>            Assignee: Prashanth Menon
>              Labels: bugs
>         Attachments: KAFKA-376-DRAFT.patch, KAFKA-376-v1.patch, 
> KAFKA-376-v2.patch, KAFKA-376-v3.patch, KAFKA-376-v4.patch, 
> KAFKA-376-v5.patch, KAFKA-376-v6.patch
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Currently, the broker always uses highwatermark to calculate the available 
> bytes to a fetch request, no matter where the request is from. Instead, we 
> should use highwatermark for requests coming from real consumer clients and 
> use logendoffset for requests coming from follower replicas.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to