[
https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449056#comment-13449056
]
Jay Kreps commented on KAFKA-458:
---------------------------------
Also, I think KafkaApis.readMessageSet should no longer catch the the exception
and return an Either[Short,MessageSet] I think. This was a bit of a hack and
makes the code in KafkaApis.readMessageSets a little hard to read (i.e. the
reference to left and right would be more clear as a try/catch since that is
what it is).
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch, kafka-458-v2.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep
> errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
