[
https://issues.apache.org/jira/browse/KAFKA-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452133#comment-13452133
]
Jun Rao commented on KAFKA-458:
-------------------------------
Thanks for patch v3. Some comments:
1. Could you rebase?
2. javaapi.ByteBufferMessageSet.hash(): should we just call the underlying
hashcode?
3. KafkaApis.readMessageSet(fetchRequest): Could you fix the indentation of
try/catch?
4. PartitionTopicInfo.enqueueError can be removed since it's no longer used.
> remove errorcode from ByteBufferMessageSet
> ------------------------------------------
>
> Key: KAFKA-458
> URL: https://issues.apache.org/jira/browse/KAFKA-458
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Swapnil Ghike
> Labels: optimization
> Fix For: 0.8
>
> Attachments: kafka-458-v1.patch, kafka-458-v2.patch,
> kafka-458-v3.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Since the FetchResponse already has errorcode, there is no need to keep
> errorcode in ByteBufferMessageSet any more.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
