[ 
https://issues.apache.org/jira/browse/KAFKA-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452074#comment-13452074
 ] 

Jun Rao commented on KAFKA-495:
-------------------------------

Thanks for the patch for 0.8. Overall, it looks good. Some minor comments.

80. LogManager:
80.1. We don't need to verify the topic name in getLog() since logs are not 
created there. Verifying it in createLog is enough.
80.2. Get rid of unused imports.

81. TopicNameValidator: get rid of "/**/"

                
> Handle topic names with "/" on Kafka server
> -------------------------------------------
>
>                 Key: KAFKA-495
>                 URL: https://issues.apache.org/jira/browse/KAFKA-495
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.7, 0.8
>            Reporter: Neha Narkhede
>            Assignee: Swapnil Ghike
>              Labels: bugs
>             Fix For: 0.8, 0.7.1
>
>         Attachments: kafka-495-v0.8.patch, kafka-495-v1.patch, 
> kafka-495-v2.patch, kafka-495-v3.patch, kafka-495-v4.patch
>
>
> If a producer publishes data to topic "foo/foo", the Kafka server ends up 
> creating an invalid directory structure on the server. This corrupts the 
> zookeeper data structure for the topic - /brokers/topics/foo/foo. This leads 
> to rebalancing failures on the consumer as well as errors on the zookeeper 
> based producer. 
> We need to harden the invalid topic handling on the Kafka server side to 
> avoid this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to