[
https://issues.apache.org/jira/browse/KAFKA-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453157#comment-13453157
]
Jun Rao commented on KAFKA-495:
-------------------------------
Thanks for 0.8 patch v2. Some additional comments:
1. KafkaApis: Instead of adding maxTopicNameLength in the constructor, we can
get that value from replicaManager.config.
2. CreateTopicCommand.createTopic(): Could we put topicNameValidator as the
last parameter that defaults to an instance of topicNameValidator with the
default max length. This way, most existing unit tests don't have to create a
separate topicNameValidator.
3. TopicTest: Is there a particular reason that the following loop is not from
1 to 5 instead?
for (i <- 3 to 8)
> Handle topic names with "/" on Kafka server
> -------------------------------------------
>
> Key: KAFKA-495
> URL: https://issues.apache.org/jira/browse/KAFKA-495
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.7, 0.8
> Reporter: Neha Narkhede
> Assignee: Swapnil Ghike
> Labels: bugs
> Fix For: 0.8, 0.7.1
>
> Attachments: kafka-495-v0.8.patch, kafka-495-v0.8-v2.patch,
> kafka-495-v1.patch, kafka-495-v2.patch, kafka-495-v3.patch, kafka-495-v4.patch
>
>
> If a producer publishes data to topic "foo/foo", the Kafka server ends up
> creating an invalid directory structure on the server. This corrupts the
> zookeeper data structure for the topic - /brokers/topics/foo/foo. This leads
> to rebalancing failures on the consumer as well as errors on the zookeeper
> based producer.
> We need to harden the invalid topic handling on the Kafka server side to
> avoid this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
