[
https://issues.apache.org/jira/browse/KAFKA-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13467868#comment-13467868
]
Jun Rao commented on KAFKA-432:
-------------------------------
Thanks for patch v1. Some comments:
1. ReplicaManager.getLocalReplica(): We shouldn't be creating a new replica in
this method. Also, this function is almost the same as getReplica() except that
it wants to throw an exception if the replica is not found. How about creating
a new method getReplicaOrException that calls getReplica and throws an
exception if replica is none?
2. object MessageFormatter: remove the extra empty lines above.
3. RequestOrResponse: Could we change LowLevelConsumerId to DebuggingConsumerId
so that people is aware that it's only for debugging purpose?
4. remove unused imports
5. SimpleConsumerShell:
5.1 The comment for the --offset is inaccurate. -2 is from beginning.
5.2 The --server option should be changed to --broker-list and the format
should be changed accordingly (to take in a list).
5.3 Can we add a command line option to print out the offset for each message
too?
5.4 Could we add a command line option to specify the maxWaitMs for each fetch
request and defaults it to 1000ms? Also, in FetchRequestBuilder, could we set
the default maxWait and minBytes to that in ConsumerConfig object, instead of
FetchRequest?
Could you also rebase?
> allow consumer to read from followers
> -------------------------------------
>
> Key: KAFKA-432
> URL: https://issues.apache.org/jira/browse/KAFKA-432
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Yang Ye
> Priority: Blocker
> Labels: optimization
> Attachments: kafka_432_v1.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> For debugging purpose, it would be convenient if we allow a consumer to
> consume from a follower replica.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
