[
https://issues.apache.org/jira/browse/KAFKA-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474720#comment-13474720
]
Neha Narkhede commented on KAFKA-432:
-------------------------------------
Thanks for the patch! Overall, looks pretty good. A few more comments -
1. FetchRequest
1.1 isFromOrdinaryConsumer and isFromLowLevelConsumer methods are unused. How
about adding them when we have a use for them ?
1.2 If you still want to keep them, rename isFromLowLevelConsumer to
isFromDebuggingConsumer to be consistent
2. FetchResponse
Revert this file since you changed the spacing between the ( and { at the end
of a function name and that does not conform with our coding convention
3. KafkaApis
The following statements are not easy to understand and should not be at info
level
info("bytes readable: " + bytesReadable)
info("data read: " + dataRead)
For example, if you read them in a busy Kafka log, would you be able to make
sense of it ?
3. OffsetRequest
Rename isFromLowLevelClient to isFromDebuggingClient
4. SimpleConsumer
In earliestOrLatestOffset API, the response variable is never used
5. SimpleConsumerShell
1. You don't have a space between ) and { at the start of few blocks. We have
been following the convention of including a space between those, please can
you conform to convention in all your patches ?
2. There is one very-long-statement in the file. Please can you break it ?
> allow consumer to read from followers
> -------------------------------------
>
> Key: KAFKA-432
> URL: https://issues.apache.org/jira/browse/KAFKA-432
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Yang Ye
> Priority: Blocker
> Labels: optimization
> Attachments: kafka_432_v1.diff, kafka_432_v2.diff, kafka_432_v3.diff,
> kafka_432_v4.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> For debugging purpose, it would be convenient if we allow a consumer to
> consume from a follower replica.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
