[
https://issues.apache.org/jira/browse/KAFKA-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468863#comment-13468863
]
Joel Koshy commented on KAFKA-510:
----------------------------------
Thanks for patch v1. I have a few comments:
1 - Condition in KafkaApis.handleProducerRequest should be made clear. I think
this would be clearer to understand:
(! produceRequest.data.keySet.exists(m =>
replicaManager.replicationFactorForPartitions.get(m.topic, m.partition) > 1))
2 - Also, can you remove the info log that you added in handleProducerRequest.
3 - Revert the test/resources/log4j change.
4 - Partition.scala.isUnderReplicated should use this change to report
under-replicated partitions correctly.
> broker needs to know the replication factor per partition
> ---------------------------------------------------------
>
> Key: KAFKA-510
> URL: https://issues.apache.org/jira/browse/KAFKA-510
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Jun Rao
> Assignee: Yang Ye
> Priority: Blocker
> Labels: bugs
> Fix For: 0.8
>
> Attachments: kafka_510_v1.diff
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> A broker needs to know the replication factor to report under replicated
> partitions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
