[ https://issues.apache.org/jira/browse/KAFKA-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469950#comment-13469950 ]
Joel Koshy commented on KAFKA-510: ---------------------------------- Looks good - one minor change I forgot to mention is to use the TopicAndPartition case class instead of a (String, Int) tuple for the pool you added. We still have many such tuples scattered all over the code, but I think going forward we should avoid doing so. > broker needs to know the replication factor per partition > --------------------------------------------------------- > > Key: KAFKA-510 > URL: https://issues.apache.org/jira/browse/KAFKA-510 > Project: Kafka > Issue Type: Bug > Components: core > Reporter: Jun Rao > Assignee: Yang Ye > Priority: Blocker > Labels: bugs > Fix For: 0.8 > > Attachments: kafka_510_v1.diff, kafka_510_v2.diff > > Original Estimate: 24h > Remaining Estimate: 24h > > A broker needs to know the replication factor to report under replicated > partitions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira