[
https://issues.apache.org/jira/browse/KAFKA-508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469566#comment-13469566
]
Joel Koshy commented on KAFKA-508:
----------------------------------
Joe, thanks for the patch. Actually, do you think we can also get rid of
the partition field from the PartitionDataProducerRequest and
PartitionDataFetchResponse? It seems redundant since the map key already
uses (TopicAndPartition). So PartitionDataProducerRequest will become
unnecessary, and PartitionDataFetchResponse can get rid of the partition
member. This shouldn't require further changes to the wire protocol (beyond
your current change), but there are some places in the code that will need to be
fixed. So we can consider doing this in a separate non-blocker jira as
getting the wire protocol change in is more important.
BTW, personally I prefer ProducerRequestPartitionData "AB" and
FetchResponsePartitionData "AB" would be better than "BA". What say?
> split out partiondata from fetchresponse and producerrequest
> ------------------------------------------------------------
>
> Key: KAFKA-508
> URL: https://issues.apache.org/jira/browse/KAFKA-508
> Project: Kafka
> Issue Type: Bug
> Reporter: Joe Stein
> Assignee: Joe Stein
> Priority: Blocker
> Labels: optimization
> Fix For: 0.8
>
> Attachments: KAFKA-508.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
