[
https://issues.apache.org/jira/browse/KAFKA-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469960#comment-13469960
]
Jun Rao edited comment on KAFKA-502 at 10/5/12 12:43 PM:
---------------------------------------------------------
Thanks for patch v4. A comment and a couple of questions:
40. In the test case description, sometimes we use mode => sync and some other
times we use "mode is changed to sync". Let's make it consistent. I think mode
=> sync is better.
41. Do all new tests pass right now? How long will it take to run all tests?
42. run_sanity.sh does run now. It seems to take more than 10 minutes now,
though it used to be less than 6 minutes. Is this expected?
was (Author: junrao):
Thanks for patch v4. A comment and a couple of questions:
40. In the test case description, sometimes we use mode => sync and some other
times we use "mode is changed to sync". Let's make it consistent. I think mode
=> sync is better.
41. Do all new tests pass right now? How long will it take to run all tests?
42. run_sanity.sh does run now. It seems to take more than 10 minutes though
and it used to be less than 6 minutes. Is this expected?
> Simplify setup / initialization in replication_basic_test.py
> ------------------------------------------------------------
>
> Key: KAFKA-502
> URL: https://issues.apache.org/jira/browse/KAFKA-502
> Project: Kafka
> Issue Type: Sub-task
> Affects Versions: 0.8
> Reporter: John Fung
> Assignee: John Fung
> Labels: replication-testing
> Fix For: 0.8
>
> Attachments: kafka-502-v1.patch, kafka-502-v2.patch,
> kafka-502-v3.patch, kafka-502-v4.patch
>
>
> The setup and initialization could be simplified by moving some common code
> to a base class or some helper functions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
