[
https://issues.apache.org/jira/browse/KAFKA-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471616#comment-13471616
]
Jun Rao commented on KAFKA-502:
-------------------------------
Thanks for patch v6. A few more comments:
60. Most of the new test cases use replication factor 6. I am not sure if this
is necessary. The typical replication factor is 3. While we should cover the
case with higher replication factors, most tests should probably be using
replication factor 3.
61. The description of the changes in some of the test cases is not complete.
The following are some examples:
0003 and up: missed the change comp => 1
0005: missed the change mode => async
0006: incorrectly marked the change mode=>sync; the test seems to be the same
as 0001
0008: incorrectly marked the change mode=>sync;
0009: missed the change acks => 1
> Simplify setup / initialization in replication_basic_test.py
> ------------------------------------------------------------
>
> Key: KAFKA-502
> URL: https://issues.apache.org/jira/browse/KAFKA-502
> Project: Kafka
> Issue Type: Sub-task
> Affects Versions: 0.8
> Reporter: John Fung
> Assignee: John Fung
> Labels: replication-testing
> Fix For: 0.8
>
> Attachments: kafka-502-v1.patch, kafka-502-v2.patch,
> kafka-502-v3.patch, kafka-502-v4.patch, kafka-502-v5.patch, kafka-502-v6.patch
>
>
> The setup and initialization could be simplified by moving some common code
> to a base class or some helper functions
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
