[
https://issues.apache.org/jira/browse/KAFKA-510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473746#comment-13473746
]
Neha Narkhede commented on KAFKA-510:
-------------------------------------
1. ControllerChannelManager
Wrap the long line
2. KafkaApis
Wrap the long lines
3. LeaderAndIsrRequest
PartitionInfo is too general, mind changing it to PartitionStateInfo ?
4. PartitionStateMachine
4.1 Let's not change the NOTE back to TODO
4.2 Wrap the long lines
5. ReplicaManager
5.1 Wrap the long lines and please remember to do this carefully in each patch
5.2 Move the comment in getReplicationFactorForPartition to the API description
section of that method
5.3 Still have the same question 4.3 from previous review
5.4 Change "In recording follower position" to "While recording the follower
position"
6. ReplicaStateMachine
Wrap the long lines
> broker needs to know the replication factor per partition
> ---------------------------------------------------------
>
> Key: KAFKA-510
> URL: https://issues.apache.org/jira/browse/KAFKA-510
> Project: Kafka
> Issue Type: Bug
> Components: core
> Reporter: Jun Rao
> Assignee: Yang Ye
> Priority: Blocker
> Labels: bugs
> Fix For: 0.8
>
> Attachments: kafka_510_v1.diff, kafka_510_v2.diff, kafka_510_v3.diff,
> kafka_510_v4.diff, kafka_510_v5.diff, kafka_510_v6.diff, kafka_510_v7.diff,
> kafka_510_v8.diff
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> A broker needs to know the replication factor to report under replicated
> partitions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
