[ https://issues.apache.org/jira/browse/KAFKA-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480089#comment-13480089 ]
Jun Rao commented on KAFKA-541: ------------------------------- Thanks for the patch. Some comments: 1. I see the following error while running run_sanity.sh in system test. 2012-10-19 07:52:05,210 - ERROR - ERROR while plotting graph /home/jrao/Intellij_workspace/kafka_0.8_203/system_test/replication_testsuite/testcase_1/dashboards/broker/kafka.server:type=BrokerTopicMetrics,name=AllTopicsBytesInPerSec:OneMinuteRate.svg: float division (metrics) 2. kafka_system_test_utils.py: The following line doesn't look right and there are multiple instances of this. + addedCSVConfig["kfka.metrics.polling.interval.secsafka.csv.metrics.reporter.enabled"] = "true" 3. We probably shouldn't register the metrics reporter in Producer and ZookeeperConsumerConnector since a single jvm can create multiple instances of each. Instead, we could make a util that registers the metrics reporter and invoke it in standalone tools like ProducerPerformance and ConsoleConsumer. > Use metrics CSV reporter instead of jmx tool for system tests > ------------------------------------------------------------- > > Key: KAFKA-541 > URL: https://issues.apache.org/jira/browse/KAFKA-541 > Project: Kafka > Issue Type: Bug > Affects Versions: 0.8 > Reporter: Joel Koshy > Assignee: Yang Ye > Attachments: kafka_541_v1.diff > > > The existing system test framework spawns off a bunch of jmxtool processes to > collect metrics. This is rather heavy-weight and also, requires advance > knowledge of all the beans (many of which are dynamically registered). E.g., > per-topic stats pop-up only after the topics are produced to. > Since we are using metrics-core, we can just turn on the CSV reporter to > collect these stats. I had originally thought version 2.1.3 had various bugs > that rendered it unusable for CSV reporter, but I gave it another try and it > seems to be fine. Will post some output. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira