[
https://issues.apache.org/jira/browse/KAFKA-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13482493#comment-13482493
]
Joel Koshy commented on KAFKA-541:
----------------------------------
Delayed review, but nevertheless:
The KafkaCSVMetricsReporter object may be better named as KafkaMetricsReporter
since startCSVMetricsReporter
potentially starts up other (non-CSV) reporters (if any) as well - in which
case KafkaMetricsReporter.scala would be a
better place for it. Or, you can just filter out non-CSV reporters.
Also, the top-level/config/server.properties need not enable the csv reporter.
I thought the system test replication
suite's server.properties would need to be patched, but it isn't. Does this
mean the test suite picks up the top-level
config as a template?
I can take care of the above in some other (unrelated) jiras that I have on my
plate. However:
Can you please attach the metrics patch to fix the Timer CSV reporting? and
ideally, submit a pull-request to the
metrics project? We should get off our patched version of metrics as soon as
metrics-core@github is patched. (I had put
the metrics github hash in the previous jar so we know exactly which version of
the code we are on.)
> Use metrics CSV reporter instead of jmx tool for system tests
> -------------------------------------------------------------
>
> Key: KAFKA-541
> URL: https://issues.apache.org/jira/browse/KAFKA-541
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.8
> Reporter: Joel Koshy
> Assignee: Yang Ye
> Attachments: kafka_541_v1.diff, kafka_541_v2.diff, kafka_541_v3.diff,
> metrics-annotation-3.0.1.jar, metrics-core-3.0.1.jar
>
>
> The existing system test framework spawns off a bunch of jmxtool processes to
> collect metrics. This is rather heavy-weight and also, requires advance
> knowledge of all the beans (many of which are dynamically registered). E.g.,
> per-topic stats pop-up only after the topics are produced to.
> Since we are using metrics-core, we can just turn on the CSV reporter to
> collect these stats. I had originally thought version 2.1.3 had various bugs
> that rendered it unusable for CSV reporter, but I gave it another try and it
> seems to be fine. Will post some output.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
