[
https://issues.apache.org/jira/browse/KAFKA-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483657#comment-13483657
]
Jun Rao commented on KAFKA-340:
-------------------------------
21.2 My confusion is that I thought replicatedPartitionsBrokerLeads is a val
instead of a method. Could you change replicatedPartitionsBrokerLeads.toSet to
replicatedPartitionsBrokerLeads().toSet to indicate that there is side effect?
Also, could you add a comment to shutdownBroker() to describe what it does and
what the return value is?
21.3 Looked again. Yes, you are right. We don't need to lock there.
21.4 The code still doesn't send stopReplicaRequests for partitions whose
leader is on the broker to be shut down. This is not truly needed since the
leader won't issue any fetch request. However, it would be better to stop those
replicas too.
> Implement clean shutdown in 0.8
> -------------------------------
>
> Key: KAFKA-340
> URL: https://issues.apache.org/jira/browse/KAFKA-340
> Project: Kafka
> Issue Type: Sub-task
> Components: core
> Affects Versions: 0.8
> Reporter: Jun Rao
> Assignee: Joel Koshy
> Priority: Blocker
> Labels: bugs
> Attachments: KAFKA-340-v1.patch, KAFKA-340-v2.patch,
> KAFKA-340-v3.patch
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> If we are shutting down a broker when the ISR of a partition includes only
> that broker, we could lose some messages that have been previously committed.
> For clean shutdown, we need to guarantee that there is at least 1 other
> broker in ISR after the broker is shut down.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
