On 9/26/18 9:46 PM, Thomas De Schampheleire wrote:
El mié., 26 sept. 2018 a las 13:01, Mads Kiilerich
(<m...@kiilerich.com>) escribió:
On 9/24/18 10:45 PM, Thomas De Schampheleire wrote:
# HG changeset patch
# User Thomas De Schampheleire <thomas.de_schamphele...@nokia.com>
# Date 1537821464 -7200
# Mon Sep 24 22:37:44 2018 +0200
# Node ID 3c33619af70545eb9b3cbba585181094df67afbb
# Parent b807b1e90e61d2c8c16c5e3ec5978ef7dd7a2d31
cli: convert 'gearbox make-config' to 'kallithea config create'
Intuitively, I think I would find 'kallithea-config --create' more
obvious. But that might just be a habit. I guess it makes sense with
separate "sub-command area" and "sub-command" ... and then "--
+@config.command()
+@click.option('--show-defaults', callback=show_defaults,
+ is_flag=True, expose_value=False, is_eager=True,
+ help='Show the default values that can be overridden')
+@click.argument('config_file', type=click.Path())
+@click.argument('key_value_pairs', nargs=-1)
+def create(config_file, key_value_pairs):
+ """Create a new configuration file
+
+ This command creates a bare configuration file (possibly filling in
+ defaults from the extra variables you give).
What does "bare" mean here? It is actually quite verbose in my opinion.
I guess you are aware that this comes from the original code.
I didn't notice that. I will fix.
===
Generally, I support the direction of these patches. It seems better
than the alternatives. I hope you agree.
Please, can you polish it with the minor things we agreed on ... and
update documentation?
/Mads
_______________________________________________
kallithea-general mailing list
kallithea-general@sfconservancy.org
https://lists.sfconservancy.org/mailman/listinfo/kallithea-general
