https://bugs.kde.org/show_bug.cgi?id=515645

Nate Graham <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/plasma-desktop/-/commit/
                   |                            |ec6b7be2e963786cc643dc027f6
                   |                            |b9af6139d9831
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Nate Graham <[email protected]> ---
Git commit ec6b7be2e963786cc643dc027f6b9af6139d9831 by Nate Graham, on behalf
of Harald Sitter.
Committed on 19/02/2026 at 16:00.
Pushed by ngraham into branch 'master'.

gamecontroller: make devicemodel a singleton

previously we had two instances of the model (one for figuring out
whether to show the kcm, one for the kcm). but since this model is based
on event polling we'd end up only receiving events in one of the models,
rendering the other model broken (not having any devices).

instead DeviceModel is now a singleton used in both contexts. it's a bit
awkward because technically we could have it owned by something but oh
well.

this also fixes a theoretical memory leak because the devicemodel in the
moduledata wasn't properly managed

M  +10   -1    kcms/gamecontroller/devicemodel.h
M  +2    -3    kcms/gamecontroller/gamecontrollermoduledata.cpp
M  +0    -2    kcms/gamecontroller/gamecontrollermoduledata.h
M  +1    -1    kcms/gamecontroller/kcm.cpp
M  +9    -9    kcms/gamecontroller/ui/main.qml

https://invent.kde.org/plasma/plasma-desktop/-/commit/ec6b7be2e963786cc643dc027f6b9af6139d9831

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to