https://bugs.kde.org/show_bug.cgi?id=527752
--- Comment #1 from Duncan <[email protected]> --- (In reply to Duncan from comment #0) > Note: Bug #511384 [mentions] that system settings had an > option to control where it was placed. But a year later [...] if the PIP > options in system settings remain I can't find them OK, if I'm understanding the code logic I'm reading I think I know why I don't see the system settings PIP options: 1) MovementAndPlacement.qml has a Kirigami.FormGroup with title "Picture-in-picture Placement", but... 2) Said group has a condition: visible: kcm.isPiPEnabled 3) Which is apparently controlled by kwinoptions.cpp isPiPEnabled 4) Which is in turn exclusively conditioned on: return qEnvironmentVariableIsSet("KWIN_WAYLAND_SUPPORT_XX_PIP_V1") But the above-mentioned 889d commit "Enable pip by default" logic no longer depends on JUST that variable, but instead on that variable .value_or(true). So the commit enabling pip by default did just that, enabling pip by default while bypassing the variable, without changing the exclusive variable-controlled logic of kwinoptions.cpp, which means people that don't have that variable set still don't see the pip placement options in MovementAndPlacement.qml despite pip being enabled by default. That is therefore a sub-bug, but fixing the logic to enable the kcm's pip placement options won't fully solve this bug because it still does nothing for the rest of what my window rules did, specifically allowing me to make the window BELOW instead of ABOVE, to initialize with vertical maximized so the pip window remains full-monitor height while allowing width to vary with ratio (so a 16:9 video followed by 9:16 followed by 16:9 will remain full-monitor height throughout, varying the width based on ratio). Further, while I can't see and thus haven't tried those screen-corner and margin options, they don't give me control of whether that "corner" is corner-of-monitor or corner-of-viewport like the rule position 0 x 2160 does. Plus, while a window rule allows me to specify firefox-PIP-specific behavior, the kcm option would apply to any PiP window, and as pip mode becomes more common it's quite likely I'll want firefox pip window behavior different from what I want other pip windows to do. (That is, it's quite possible I'll want other pip windows to retain the normal pip ABOVE behavior, while I still want firefox pip windows BELOW instead, and window rules is the already existing way to allow such configuration, PROVIDED window rules actually work for pip windows instead of being ignored.) -- You are receiving this mail because: You are watching all bug changes.
