https://bugs.kde.org/show_bug.cgi?id=384321
Pali Rohár <pali.ro...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|FIXED |---
Status|RESOLVED |REOPENED
--- Comment #3 from Pali Rohár <pali.ro...@gmail.com> ---
> - if
> (QFileInfo(QString::fromUtf8(storage.device())).canonicalFilePath() ==
> canonicalDeviceNode ) {
> + if
> (QFileInfo(QString::fromLocal8Bit(storage.device())).canonicalFilePath() ==
> canonicalDeviceNode ) {
This does not look like a correct change. As I wrote in first comment, for
decoding and encoding file names QFile::decodeName() resp. QFile::decodeName()
should be used:
http://doc.qt.io/qt-5/qfile.html#decodeName
http://doc.qt.io/qt-5/qfile.html#encodeName
And when starting external program with env LC_ALL=C then
QString::fromLocal8Bit() and toLocal8Bit() is also wrong as LC_ALL=C define
ASCII encoding. So some equivalent of "to 7bit ASCII" and "from 7bit ASCII"
should be used (seems that QString does not provide ASCII transformation
functions yet).
--
You are receiving this mail because:
You are watching all bug changes.
