https://bugs.kde.org/show_bug.cgi?id=384321

--- Comment #4 from Andrius Štikonas <andr...@stikonas.eu> ---
(In reply to Pali Rohár from comment #3)
> > -        if 
> > (QFileInfo(QString::fromUtf8(storage.device())).canonicalFilePath() == 
> > canonicalDeviceNode ) {
> > +        if 
> > (QFileInfo(QString::fromLocal8Bit(storage.device())).canonicalFilePath() == 
> > canonicalDeviceNode ) {
> 
> This does not look like a correct change. As I wrote in first comment, for
> decoding and encoding file names QFile::decodeName() resp.
> QFile::decodeName() should be used:
> 
> http://doc.qt.io/qt-5/qfile.html#decodeName
> http://doc.qt.io/qt-5/qfile.html#encodeName

Hmm, but can block device name even be encoded? I was looking for some
documentation, but it looks to be always ASCII. I was indeed looking at those
decodeName functions but aren't they unnecessary for ASCII.

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to