https://bugs.kde.org/show_bug.cgi?id=359289
Florian Krohm <flor...@eich-krohm.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |flor...@eich-krohm.de
--- Comment #3 from Florian Krohm <flor...@eich-krohm.de> ---
(In reply to Andreas Arnez from comment #1)
> Created attachment 97264 [details]
> Implement popcnt for s390x
>
> Suggested fix for this Bug.
Thanks for the patch.
As Mark said: none/tests/s390x/Makefile.am needs adjustment. Otherwise the
popcnt test does not get built during "make check".
In opcodes.h you define POPCNT. Good! Why not use it in popcnt.c?
Can you add a check_popcnt call in popcnt.c where all input bits are 1?
We also need configury to check whether the machine has the POPCNT insn. And
only if the machine supports that opcode we should build the test.
Other than that the patch looks good.
--
You are receiving this mail because:
You are watching all bug changes.
