https://bugs.kde.org/show_bug.cgi?id=359289
Florian Krohm <flor...@eich-krohm.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
--- Comment #6 from Florian Krohm <flor...@eich-krohm.de> ---
(In reply to Andreas Arnez from comment #4)
> > In opcodes.h you define POPCNT. Good! Why not use it in popcnt.c?
> Just a matter of taste. I prefer leaving the choice of operand registers to
> the compiler, like you would do in production code.
I've added opcodes.h mainly to deal with certain issues in old binutils
versions. I don't recall exactly what those problems were.
> Can you add a check_popcnt call in popcnt.c where all input bits are 1?
> Sure. Any particular reason for testing this specific value?
I like to test boundary values.
> > We also need configury to check whether the machine has the POPCNT insn. And
> > only if the machine supports that opcode we should build the test.
> Not sure about that one. The patch always emulates the instruction,
> independent of the host capabilities.
Right! Not sure what I was thinking.
Thanks for the respin. I've added the patch as r15792 and VEX r3210
--
You are receiving this mail because:
You are watching all bug changes.
