https://bugs.kde.org/show_bug.cgi?id=443656

Harald Sitter <sit...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/khotkeys/commit/97f9339f
                   |                            |d96d97e012347f8f7fca987bbe4
                   |                            |fca0d
   Version Fixed In|                            |5.23.5
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from Harald Sitter <sit...@kde.org> ---
Git commit 97f9339fd96d97e012347f8f7fca987bbe4fca0d by Harald Sitter.
Committed on 15/11/2021 at 06:59.
Pushed by sitter into branch 'master'.

when deleting an entry, also delete the widgets

previously what would happen is that KCMHotkeys::currentChanged would
run, find the new index (-1,-1) now invalid and show the global settings
instead. this however left the simple_action's underlying widgets still
sitting around referring to the previous index AND holding a dangling
trigger point that would eventually crash when the simple_action would
be poked by anything

instead force unset the internal state of the simple_action when showing
the global settings.

FIXED-IN: 5.23.5

M  +3    -0    kcm_hotkeys/kcm_hotkeys.cpp
M  +11   -7    kcm_hotkeys/simple_action_data_widget.cpp
M  +3    -0    kcm_hotkeys/simple_action_data_widget.h
M  +8    -0    kcm_hotkeys/triggers/trigger_widget_base.cpp

https://invent.kde.org/plasma/khotkeys/commit/97f9339fd96d97e012347f8f7fca987bbe4fca0d

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to