https://bugs.kde.org/show_bug.cgi?id=443656
Harald Sitter <sit...@kde.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
|ma/khotkeys/commit/97f9339f |ma/khotkeys/commit/a4137ac8
|d96d97e012347f8f7fca987bbe4 |f7b18824568fbee0f3e2dce7551
|fca0d |841b7
--- Comment #3 from Harald Sitter <sit...@kde.org> ---
Git commit a4137ac8f7b18824568fbee0f3e2dce7551841b7 by Harald Sitter.
Committed on 15/11/2021 at 07:02.
Pushed by sitter into branch 'Plasma/5.23'.
when deleting an entry, also delete the widgets
previously what would happen is that KCMHotkeys::currentChanged would
run, find the new index (-1,-1) now invalid and show the global settings
instead. this however left the simple_action's underlying widgets still
sitting around referring to the previous index AND holding a dangling
trigger point that would eventually crash when the simple_action would
be poked by anything
instead force unset the internal state of the simple_action when showing
the global settings.
FIXED-IN: 5.23.5
(cherry picked from commit 97f9339fd96d97e012347f8f7fca987bbe4fca0d)
M +3 -0 kcm_hotkeys/kcm_hotkeys.cpp
M +11 -7 kcm_hotkeys/simple_action_data_widget.cpp
M +3 -0 kcm_hotkeys/simple_action_data_widget.h
M +8 -0 kcm_hotkeys/triggers/trigger_widget_base.cpp
https://invent.kde.org/plasma/khotkeys/commit/a4137ac8f7b18824568fbee0f3e2dce7551841b7
--
You are receiving this mail because:
You are watching all bug changes.
