https://bugs.kde.org/show_bug.cgi?id=464536

Arjen Hiemstra <ahiems...@heimr.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://invent.kde.org/plas
                   |                            |ma/systemsettings/commit/6e
                   |                            |086d2b836592db7096209c68ce3
                   |                            |46cb3b885c6
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from Arjen Hiemstra <ahiems...@heimr.nl> ---
Git commit 6e086d2b836592db7096209c68ce346cb3b885c6 by Arjen Hiemstra.
Committed on 07/02/2023 at 11:43.
Pushed by ngraham into branch 'master'.

sidebar: Use a proper checked state for the menu button

We don't generally override down for setting the pressed state of menu
buttons, instead we use the checked state, which is subtly different
visually.

Moreover, using onPressed here causes a weird behaviour where any
subsequent press after clicking the "highlight changed settings" menu
item will re-open the menu on wayland, probably caused by the same
source as https://bugs.kde.org/show_bug.cgi?id=464855 . Using onToggled
instead will prevent this.

M  +6    -2    sidebar/package/contents/ui/HamburgerMenuButton.qml

https://invent.kde.org/plasma/systemsettings/commit/6e086d2b836592db7096209c68ce346cb3b885c6

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to