https://bugs.kde.org/show_bug.cgi?id=464536

Nate Graham <n...@kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |5.27
      Latest Commit|https://invent.kde.org/plas |https://invent.kde.org/plas
                   |ma/systemsettings/commit/6e |ma/systemsettings/commit/a9
                   |086d2b836592db7096209c68ce3 |116045f325d68b29ebff4425ec6
                   |46cb3b885c6                 |1a4b85ee06c

--- Comment #8 from Nate Graham <n...@kde.org> ---
Git commit a9116045f325d68b29ebff4425ec61a4b85ee06c by Nate Graham, on behalf
of Arjen Hiemstra.
Committed on 07/02/2023 at 16:49.
Pushed by ngraham into branch 'Plasma/5.27'.

sidebar: Use a proper checked state for the menu button

We don't generally override down for setting the pressed state of menu
buttons, instead we use the checked state, which is subtly different
visually.

Moreover, using onPressed here causes a weird behaviour where any
subsequent press after clicking the "highlight changed settings" menu
item will re-open the menu on wayland, probably caused by the same
source as https://bugs.kde.org/show_bug.cgi?id=464855 . Using onToggled
instead will prevent this.


(cherry picked from commit 6e086d2b836592db7096209c68ce346cb3b885c6)

M  +6    -2    sidebar/package/contents/ui/HamburgerMenuButton.qml

https://invent.kde.org/plasma/systemsettings/commit/a9116045f325d68b29ebff4425ec61a4b85ee06c

-- 
You are receiving this mail because:
You are watching all bug changes.

Reply via email to