https://bugs.kde.org/show_bug.cgi?id=469445
--- Comment #33 from pallaswept <pallasw...@proton.me> --- (In reply to Nate Graham from comment #32) > For those of you who were concerned that we were just papering over the > actual bug here, you were right (though it was intentional as a quick fix), > and will hopefully be happy to learn that the actual root cause has been > identified and fixed with > https://invent.kde.org/plasma/plasma-desktop/-/commit/ > 685fac5355812cfce67c4008c38fa3fbf5f75b08. Ultimately Harald and Marco > figured it out and fixed it for good. Even better, that fix will be in > Plasma 5.27.9! TL;DR you did it the right way, but I think maybe(?) you missed a spot with the patch. Fantastic news. I wouldn't say I felt that you were 'papering over' it, in fact it was me who initially suggested (see comment 18) that a quick fix be put in place before a more complete fix was done over time. You've done exactly that, so I'm very pleased. It's not entirely clear to me though, but there may still be one outstanding issue, please refer to comment 12 - the fault here was in two parts; in brief, first that files were added recursively (which is obviously fixed by this patch) and second, that non-existent items were not removed. I'm not so sure that second part has been approached by this patch? Please forgive me, I'm not sufficiently familiar with the codebase to be able to be certain by looking at the patch, whether the cleanup is taken care of by that new file and it's two functions, or whether they are only used to filter additions to non-recursive entries.... but at a glance, it appears tha the former is the case, and the removal of non-existent entries has not been resolved by this patch. -- You are receiving this mail because: You are watching all bug changes.
