> On Oct. 15, 2016, 8:51 p.m., Michael Pyne wrote: > > kf5-applications-build-include, line 26 > > <https://git.reviewboard.kde.org/r/129117/diff/1/?file=481793#file481793line26> > > > > If the idea is to build everything in kdegraphics then it is probably > > better to replace all of these sub-modules with something like `use-modules > > kde/kdegraphics`. > > > > The `kde/` is itself redundant and unnecessary, that's just an effort > > to make it clear it's not simply a single repository name.
Michael: my goal was to have a way to build *everything* that is KF5/Qt5 ready. This does mean adding each and every module into a file somewhere, although of course people don't have to include these files. My idea was, one file per "product", so people can grab "all of frameworks" or "all of plasma" or "all apps", and if they want a subset they can just copy/paste that subset they want to compile into their own file. Defining instead what is "essential" and what is not sounds like a very fuzzy topic, subject to endless debates. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129117/#review100026 ----------------------------------------------------------- On Oct. 10, 2016, 10:07 a.m., Tomaz Canabrava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129117/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 10:07 a.m.) > > > Review request for Build System. > > > Repository: kdesrc-build > > > Description > ------- > > Kirigami is now needed to run discover, so it should be build > Purpose is needed by at least kamoso. > > Signed-off-by: Tomaz Canabrava <tcanabr...@kde.org> > > Add Kamoso to the buildsystem. > > Kamoso was missing from kdegraphics. > > Signed-off-by: Tomaz Canabrava <tcanabr...@kde.org> > > > Diffs > ----- > > kf5-applications-build-include f53c0233ba46322829076db3437cf9c62a65ff8e > kf5-frameworks-build-include a88498e3248262d2e1fddacd726e1ef06a3ac1e4 > > Diff: https://git.reviewboard.kde.org/r/129117/diff/ > > > Testing > ------- > > > Thanks, > > Tomaz Canabrava > >
