> On Nov. 5, 2016, 9:14 a.m., David Faure wrote: > > Ship It! > > David Faure wrote: > I withdraw my approval. Please revert. > I just noticed that these modules have been added for the "frameworks" > module-set. This doesn't make sense, they are not part of frameworks. When I > type "kdesrc-build frameworks" I expect that only the real KF5 modules will > be built. > > purpose is in playground/libs. If it's needed by kamoso, then it should > be moved to extragear/libs and added to kf5-extragear-build-include. Follow > the review process for this to happen. > > kirigami is in extragear/libs. If it's required by discover, it should be > moved to kde/workspace, and then it can be added in > kf5-workspace-build-include (ask the plasma people if they agree, then file a > sysadmin request for the move). If it's also needed by applications, then it > needs to be turned into a proper framework. > > Nicolás Alvarez wrote: > kamoso in extragear depending on purpose in playground does seem weird, > and maybe purpose should be moved to extragear. > > However, I don't think a library (kirigami) that is needed by > applications should be forced to follow the KF5 release schedule. In terms of > versioning, it should be handled the same as a third-party library. They can > release when they want, and applications can bump the dependency when they > need to.
I'm with David here. Libraries should also stop abusing KF5* - that prefix is exclusively reserved for Frameworks. Due to the manner in which development code often depends on other development code - especially for libraries such as Purpose - i'm strongly in favour of Workspace/Applications only being allowed to depend on libraries in the same release unit or Frameworks (for libraries maintained by KDE anyway). In any case, depending on Playground should definitely be forbidden (you shouldn't be releasing code from Playground anyway). - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129117/#review100589 ----------------------------------------------------------- On Nov. 7, 2016, 9:39 a.m., Tomaz Canabrava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129117/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 9:39 a.m.) > > > Review request for Build System. > > > Repository: kdesrc-build > > > Description > ------- > > Kirigami is now needed to run discover, so it should be build > Purpose is needed by at least kamoso. > > Signed-off-by: Tomaz Canabrava <tcanabr...@kde.org> > > Add Kamoso to the buildsystem. > > Kamoso was missing from kdegraphics. > > Signed-off-by: Tomaz Canabrava <tcanabr...@kde.org> > > > Diffs > ----- > > kf5-applications-build-include f53c0233ba46322829076db3437cf9c62a65ff8e > kf5-frameworks-build-include a88498e3248262d2e1fddacd726e1ef06a3ac1e4 > > Diff: https://git.reviewboard.kde.org/r/129117/diff/ > > > Testing > ------- > > > Thanks, > > Tomaz Canabrava > >
