apol added a comment.
The patch makes sense. +1
INLINE COMMENTS
> ECMAddAppIcon.cmake:154
> + set(ext "${CMAKE_MATCH_4}")
> + if(NOT ${icon_type} STREQUAL ".svg" OR NOT ${icon_type}
> STREQUAL ".svgz")
> + message(AUTHOR_WARNING "${icon_full} is not a SVG file -
> ignoring")
this if could go up to where we're checking the icon name in an elseif up at
line 146.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D22958
To: hein, #frameworks, mart, leinir, apol
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy,
michaelh, ngraham, bruns
