hein added inline comments. INLINE COMMENTS
> apol wrote in ECMAddAppIcon.cmake:154 > this if could go up to where we're checking the icon name in an elseif up at > line 146. We'd need to do a `get_filename_component` there and end up either pulling the `ext` thing out twice (unless CMake doesn't do block scoping) or ahead of the `ABSOLUTE` one and then possibly unnecessarily. FWIW I copied that entire regex block out of ECMInstallIcons.cmake to play it safe so I'd prefer not touching it ... :-) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22958 To: hein, #frameworks, mart, leinir, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
