----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4320/ -----------------------------------------------------------
(Updated 2010-11-14 22:47:28.342220) Review request for kdelibs, Raphael Kubo da Costa, Jonathan Thomas, Aurélien Gâteau, Jonathan Riddell, Adenilson Cavalcanti, and loureiro. Changes ------- Updated patch fixing some errors and requested changes. I did not added docstrings and unity tests. @rakuco: How can we replace the "KSambaShareData *"? The QMap and QList only accept it when it is a pointer. Summary ------- KDE needs to support modern samba tools. With the "net usershare" command line tool the users can manage their shares. The attached patch intends to add support for this tool. Diffs (updated) ----- /trunk/KDE/kdelibs/includes/CMakeLists.txt 1180108 /trunk/KDE/kdelibs/kio/CMakeLists.txt 1180108 /trunk/KDE/kdelibs/kio/kio/ksambashare.h 1180108 /trunk/KDE/kdelibs/kio/kio/ksambashare.cpp 1180108 /trunk/KDE/kdelibs/kio/kio/ksambashare_p.h PRE-CREATION /trunk/KDE/kdelibs/kio/kio/ksambasharedata.h PRE-CREATION /trunk/KDE/kdelibs/kio/kio/ksambasharedata.cpp PRE-CREATION /trunk/KDE/kdelibs/kio/kio/ksambasharedata_p.h PRE-CREATION Diff: http://svn.reviewboard.kde.org/r/4320/diff Testing ------- Thanks, Rodrigo
