----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4320/#review8836 -----------------------------------------------------------
I think we're finally getting there :) dfaure might know better about the KDirWatch stuff; apart from that, the appropriate @since tags need to be added, as well as the missing method apidox. After that it's probably r+ from me. - Raphael On 2010-11-19 01:13:16, Rodrigo Belem wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/4320/ > ----------------------------------------------------------- > > (Updated 2010-11-19 01:13:16) > > > Review request for kdelibs, Raphael Kubo da Costa, Jonathan Thomas, Aurélien > Gâteau, Jonathan Riddell, Adenilson Cavalcanti, loureiro, and Daniel > Nicoletti. > > > Summary > ------- > > KDE needs to support modern samba tools. With the "net usershare" command > line tool the users can manage their shares. The attached patch intends to > add support for this tool. > > > Diffs > ----- > > /trunk/KDE/kdelibs/includes/CMakeLists.txt 1180108 > /trunk/KDE/kdelibs/kio/CMakeLists.txt 1180108 > /trunk/KDE/kdelibs/kio/kio/ksambashare.h 1180108 > /trunk/KDE/kdelibs/kio/kio/ksambashare.cpp 1180108 > /trunk/KDE/kdelibs/kio/kio/ksambashare_p.h PRE-CREATION > /trunk/KDE/kdelibs/kio/kio/ksambasharedata.h PRE-CREATION > /trunk/KDE/kdelibs/kio/kio/ksambasharedata.cpp PRE-CREATION > /trunk/KDE/kdelibs/kio/kio/ksambasharedata_p.h PRE-CREATION > > Diff: http://svn.reviewboard.kde.org/r/4320/diff > > > Testing > ------- > > > Thanks, > > Rodrigo > >