----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6004/#review9021 -----------------------------------------------------------
one tiny thing: calling it setDialogsAllowed would be clearer than setDialogsActive. I'd check 'ship it' but this isn't my code at all :) - Chani On 2010-11-28 19:53:45, Matthias Fuchs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6004/ > ----------------------------------------------------------- > > (Updated 2010-11-28 19:53:45) > > > Review request for kdelibs and David Faure. > > > Summary > ------- > > Adds method to KBookmarkManager disable showing dialogs on errors. > This way it is possible to deactivate those messages if KBoomarkManager is > not run in the gui thread. > BUG:207592 > > > Diffs > ----- > > /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h 1201809 > /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.cc 1201809 > > Diff: http://svn.reviewboard.kde.org/r/6004/diff > > > Testing > ------- > > > Thanks, > > Matthias > >