----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6004/ -----------------------------------------------------------
(Updated 2010-11-30 20:55:09.801653) Review request for kdelibs and David Faure. Changes ------- Adds a error signal that contains the translated error message. To be able to emit it a const_cast is needed in saveAs, which we -- Albert and me -- are not that happy about. :) Summary ------- Adds method to KBookmarkManager disable showing dialogs on errors. This way it is possible to deactivate those messages if KBoomarkManager is not run in the gui thread. BUG:207592 Diffs (updated) ----- /trunk/KDE/kdelibs/kate/plugins/autobrace/ktexteditor_autobrace.desktop 1201809 /trunk/KDE/kdelibs/kate/syntax/katehighlight.cpp 1201809 /trunk/KDE/kdelibs/kdecore/io/kzip.cpp 1201809 /trunk/KDE/kdelibs/kdecore/kernel/kglobal.h 1201809 /trunk/KDE/kdelibs/kdecore/kernel/kglobal.cpp 1201809 /trunk/KDE/kdelibs/kdecore/kernel/kstandarddirs.cpp 1201809 /trunk/KDE/kdelibs/kdecore/localization/all_languages.desktop 1201809 /trunk/KDE/kdelibs/kdecore/tests/kstandarddirstest.cpp 1201809 /trunk/KDE/kdelibs/kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.h 1201809 /trunk/KDE/kdelibs/kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp 1201809 /trunk/KDE/kdelibs/kdeui/shortcuts/kglobalaccel.cpp 1201809 /trunk/KDE/kdelibs/kdeui/util/kpixmapsequence.h 1201809 /trunk/KDE/kdelibs/kdeui/util/kpixmapsequence.cpp 1201809 /trunk/KDE/kdelibs/kdeui/widgets/kmultitabbar.cpp 1201809 /trunk/KDE/kdelibs/kdewebkit/kwebpage.cpp 1201809 /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.h 1201809 /trunk/KDE/kdelibs/kio/bookmarks/kbookmarkmanager.cc 1201809 /trunk/KDE/kdelibs/kio/kfile/kfilemetadatawidget.h 1201809 /trunk/KDE/kdelibs/kio/kfile/kfilemetadatawidget.cpp 1201809 /trunk/KDE/kdelibs/kio/kio/accessmanager.cpp 1201809 /trunk/KDE/kdelibs/kio/kio/accessmanagerreply_p.cpp 1201809 /trunk/KDE/kdelibs/kio/kio/kfilemetainfo.cpp 1201809 /trunk/KDE/kdelibs/nepomuk/query/query.cpp 1201809 /trunk/KDE/kdelibs/nepomuk/utils/utils.cpp 1201809 /trunk/KDE/kdelibs/plasma/widgets/label.cpp 1201809 /trunk/KDE/kdelibs/plasma/widgets/pushbutton.cpp 1201809 /trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1201809 /trunk/KDE/kdelibs/plasma/widgets/tabbar.cpp 1201809 /trunk/KDE/kdelibs/solid/solid/CMakeLists.txt 1201809 /trunk/KDE/kdelibs/solid/solid/backends/udev/udevblock.h PRE-CREATION /trunk/KDE/kdelibs/solid/solid/backends/udev/udevblock.cpp PRE-CREATION /trunk/KDE/kdelibs/solid/solid/backends/udev/udevdevice.cpp 1201809 /trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp 1201809 Diff: http://svn.reviewboard.kde.org/r/6004/diff Testing ------- Thanks, Matthias