-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6111/#review9248
-----------------------------------------------------------


The real question is whether this mimetype is used for files, or only for 
internal "fake" purposes. If for files, then it should be added to 
shared-mime-info (Pino or I can help with that).
But if I remember correctly in this case it's not about files, which is why a 
fake mimetype is used. In that case, I'd rather not reuse an existing file 
mimetype, but rather use a kde-specific fake name.

- David


On 2010-12-13 17:07:48, Rex Dieter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6111/
> -----------------------------------------------------------
> 
> (Updated 2010-12-13 17:07:48)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch adjusts the kde "fake" mimetype fonts/package so 
> desktop-file-utils/shared-mime-info doesn't complain (using 
> application/vnd.kde.fontspackage instead).  Addresses bugs #235564, #250924
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/kcontrol/kfontinst/apps/kfontview.desktop 
> 1206154 
>   /trunk/KDE/kdelibs/mimetypes/kde.xml 1206154 
> 
> Diff: http://svn.reviewboard.kde.org/r/6111/diff
> 
> 
> Testing
> -------
> 
> confirmed no warnings/errors from desktop-file-utils/shared-mime-info
> 
> 
> Thanks,
> 
> Rex
> 
>

Reply via email to