----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100873/#review2040 -----------------------------------------------------------
Hmm, this whole block is inside "if (failedAuth>0)", so this means kio_ftp tried to log in, but without using the cached credentials? Ah, probably because it tries anonymous first. Which kind of sucks on sites where you have recorded a password into kwallet... So I'm not objecting this patch, feel free to commit, but I actually think a better fix would be "if cached credentials, then use them for the first attempt" (like kio_sftp does, I think). And then the code you touched (handling of failed auth) doesn't have to change. - David On March 17, 2011, 2:44 p.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100873/ > ----------------------------------------------------------- > > (Updated March 17, 2011, 2:44 p.m.) > > > Review request for kdelibs. > > > Summary > ------- > > The attached patch forces kio_ftp to first look up for cached password before > showing the user a prompt to enter password information. This addresses the > issue mentioned in 143488 and makes kio_ftp's behavior consistent with the > other ioslaves. > > > This addresses bugs 124675 and 143488. > http://bugs.kde.org/show_bug.cgi?id=124675 > http://bugs.kde.org/show_bug.cgi?id=143488 > > > Diffs > ----- > > kioslave/ftp/ftp.cpp 038ac2e > > Diff: http://git.reviewboard.kde.org/r/100873/diff > > > Testing > ------- > > Login to an ftp site, save the password and visit the same site again. No > prompt. > > > Thanks, > > Dawit > >
