----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100873/#review2573 -----------------------------------------------------------
Ship it! Thanks, looks good to me. I do think that if I have a stored login/password for an ftp site, then I don't want to get an anonymous login when I go back there again, typically one can access more stuff with authenticated login. This raises the question of how to test anonymous login on a site with cached auth though -- well, there's always the option of renaming stuff in kwalletmanager ;) - David On March 19, 2011, 4:37 a.m., Dawit Alemayehu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100873/ > ----------------------------------------------------------- > > (Updated March 19, 2011, 4:37 a.m.) > > > Review request for kdelibs. > > > Summary > ------- > > The attached patch forces kio_ftp to first look up for cached password before > showing the user a prompt to enter password information. This addresses the > issue mentioned in 143488 and makes kio_ftp's behavior consistent with the > other ioslaves. > > > This addresses bugs 124675 and 143488. > http://bugs.kde.org/show_bug.cgi?id=124675 > http://bugs.kde.org/show_bug.cgi?id=143488 > > > Diffs > ----- > > kioslave/ftp/ftp.cpp 95c4450 > > Diff: http://git.reviewboard.kde.org/r/100873/diff > > > Testing > ------- > > Login to an ftp site, save the password and visit the same site again. No > prompt. > > > Thanks, > > Dawit > >
