----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101919/ -----------------------------------------------------------
Review request for KDE Base Apps, David Faure and Peter Penz. Summary ------- At the point where m_viewModeController->setUrl(url) was invoked in current code, the view does not yet exist because it is only created in applyViewProperties(). Moving the call after view creation is not enough however. The DolphinView's url itself has to be set, that implies setting the url of the VMC. Correcting this makes the showEvent() hack unnecessary. Diffs ----- dolphin/src/views/dolphinview.h 48967e6 dolphin/src/views/dolphinview.cpp 681ce74 Diff: http://git.reviewboard.kde.org/r/101919/diff Testing ------- Thanks, Marcel
